Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the target option for compilation #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the target option for compilation #5

wants to merge 1 commit into from

Conversation

pavi2410
Copy link
Member

@pavi2410 pavi2410 commented Mar 18, 2021 •
edited
Loading

This bug causes the passing of --target 7 option to fail.

@pavi2410
Fix the target option for compilation
6a2b0d5 
This bug is causing the passing  `--target 7` option for compiling `.scm` files to fail.
@pavi2410
Copy link
Member Author

Tested that the said option is now working correctly

$ java -cp kawa-1.11.jar kawa.repl --target 7 -T Screen1_java7 -C Screen1.scm
(compiling Screen1.scm to Screen1_java7)
$ javap -verbose Screen1_java7.class | grep "major version"
  major version: 51

Class file generated for Java 7 is slightly bigger than for Java 5

$ ls -al *class
-rw-r--r-- 1 Pavitra 197609 691 Mar 18 18:20 Screen1.class
-rw-r--r-- 1 Pavitra 197609 703 Mar 18 18:13 Screen1_java7.class

@pavi2410
Copy link
Member Author

https://replit.com/@pavi2410/ai2-kawa

@pavi2410
Copy link
Member Author

pavi2410 commented Nov 7, 2021

@ewpatton Could you please merge this?

@ewpatton
Copy link
Member

ewpatton commented Nov 9, 2021

I'll take a look this week

@pavi2410
Copy link
Member Author

@ewpatton Can you please revisit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavi2410 @ewpatton